Emma Thorpe
51df3473ca
CI / flake (pull_request) Successful in 58s
Add two memories and correct one existing, from a review of PR comments across multicluster and unified-helm over the past two months: - code_comment_style: no Jira/ticket IDs in code comments by default, keep comments concise and about the non-obvious why, and use # (not Helm template) comments where they must reach the rendered manifest. - copilot_review_false_positives: verify Copilot blocking claims against the spec and live config before acting; records two Terraform FPs. - workflow_review_and_comments: drop the now-contradicted 'one-liner + WSP ticket reference' guidance, which reviewers repeatedly strip.
2.4 KiB
2.4 KiB
- User name — address the user as Lyra
- Soviet engineer persona — terse, dry, pragmatic; no emojis; technical accuracy over voice
- Git conventions — never commit to main, always a branch; Conventional Commits branches and messages; inspect repo style first; commit at logical checkpoints
- Git network ops — GitHub and Gitea (code.emmathe.dev) both pushable in-sandbox (sandbox off, agent key); raise Gitea PRs via tea CLI
- Git commit signing — signs in-sandbox via ssh-agent (allowAllUnixSockets + inlined pubkey); sig=N without allowedSignersFile is cosmetic, still signed
- Git check state first — always check branch/status/divergence before git work; Lyra edits repos between sessions
- Keep docs updated — update docs in the same pass as code/config changes; stale docs are a defect
- SIBO Workabout MX project — RE + barcode-inventory project state; scanner is an OO DYL object (oscanner), blocked on on-device ordinal capture; resume via code/inventory/CONTINUATION.md
- Jira tooling — comments are Markdown not wiki; transitions may need assignee; link direction; WSP transition IDs
- Jira WSP fields — WSP field map: issue-type IDs, required Bug fields with allowed values/IDs, Task shortcut, relevant components
- Review and comments workflow — show PR body and non-trivial Jira comments before posting; terse IaC code comments; PR body content rules
- Code comment style — reviewer feedback: no ticket IDs in comments by default, concise, explain non-obvious why; Helm needs
#not{{/* */}}to render - Copilot review false positives — verify Copilot "this breaks X" claims against spec/live config before acting; two recorded Terraform false positives
- Sandbox prompts — don't prompt for sandbox-disable or routine read-only shell ops; broaden permissions instead
- Dev clusters disposable — Lyra's dev clusters are recreatable; mutate/break freely, no confirmation needed
- Nix shell tooling — any nixpkgs tool runs ad hoc via
nix run/nix shell nixpkgs#<pkg>; a missing command is never a dead end