test: prove the database lands at the device root, not in the music folder #10

Merged

lyrathorpe merged 4 commits from feat/database-in-sync into main 2026-08-26 20:38:53 +01:00

Conversation 0 Commits 4 Files Changed 5

+650 -38

4 Commits

Author	SHA1	Message	Date
Emma Thorpe	374a17474f	fix: never discard a play that has not been submitted ... Setting the logs aside after a successful submission threw away more than it had submitted. A play of a track missing from the mirror -- not yet copied, or its tags unreadable -- was counted as unresolved and then carried off with the rest, with nothing to retry it. The play happened and was lost. Two obligations now, kept separate. The original log is renamed rather than deleted, so a mistake here cannot destroy the record. And every play that was not submitted is written back into a live log, so the next run attempts it again: the unmatched ones, and anything in a batch that failed. Submission is recorded batch by batch as each is accepted, so a failure partway through knows exactly what got through. The remainder is written back and nothing is sent twice. When nothing at all is accepted the logs are left untouched. Skips and clockless entries are deliberately not retained. Neither can ever be submitted, so keeping them would mean reprocessing them for ever, and the untouched original holds them regardless. Also fixes a way to lose the lot: read_tags caught OSError and ValueError, but ffprobe failing raises CalledProcessError, which is neither. A single unreadable file aborted the whole submission rather than costing one unidentified play.	2026-08-26 18:32:05 +01:00
Emma Thorpe	f324b1b720	feat: convert Rockbox's playback log on the laptop, skipping the plugin ... Scrobbling previously needed the on-device Last.fm plugin run by hand before each sync, to turn Rockbox's playback log into AUDIOSCROBBLER format. Forgetting that step means the sync submits nothing and quietly appears not to work. Core Rockbox writes ROCKBOX_DIR/playback.log whenever "play log" is enabled, with no plugin running at all. Each line is timestamp:elapsed_ms:length_ms:path. The only thing missing is tags, and that is exactly why the plugin exists: reading them back off the player is slow. Off the mirror it is free, because the same files are already there -- so the conversion belongs on the laptop, and the plugin can be skipped entirely. A play counts as listened at half the track's length, matching the plugin's savepct default, so the two cannot disagree about what a play was. A short play is a skip. An entry with no usable timestamp is refused rather than invented, which is the clockless case again. A path that maps to nothing in the mirror is counted and reported instead of guessed at. Rotated logs are picked up too; Rockbox starts a new one past half a megabyte. All of them are renamed aside together once Last.fm has accepted the batch. A .scrobbler.log is still read when the plugin has been run and left one.	2026-08-26 18:24:12 +01:00
Emma Thorpe	19ac9e5d92	fix: stop counting by default; the pass costs more than the transfer ... The counting pass was added so the progress line could show a percentage and an estimate, and on a real card it turned out to dominate the run. Measured against the device: reading a track from the SMB mirror ran at 35 MB/s and writing to the card at 21 MB/s, while the sync itself managed tens of kilobytes per second. Neither end was slow. The cost was traversing fifty thousand files across six thousand directories on FAT, and the counting pass does that a second time, comparing both trees in full exactly as the transfer does. Counting is now opt-in behind -P. Without it the progress line still shows the running count, the transfer rate and the album in flight; the percentage and the estimate are what needed the extra walk, and they were the least useful part of the display. That the fix for "it looks hung" was itself making it slow is the sort of thing only measuring catches. The line still answers the question it was added for -- whether anything is happening -- without paying for the part that merely made it prettier.	2026-08-26 13:57:49 +01:00
Emma Thorpe	633fbbaf91	test: prove the database lands at the device root, not in the music folder ... The two tools disagree about where the root is. rsync copies artist folders into <device>/Music, while the database builder must run one level up, where .rockbox lives, and must record /Music/... paths despite reading the bytes from the mirror. device_prefix is what reconciles them, and until now that was only argued rather than demonstrated. Unprivileged user namespaces make a real bind mount possible, so the test can create an actual mount point and exercise the derivation instead of asserting the shape of the script. A stub builder records its working directory and what it could see. The test asserts the .tcd file arrives beside .rockbox rather than inside Music, that the build ran in the scratch root and not on the card, and that it could walk into the mirror through the symlink -- which is the mechanism that produces device paths from mirror bytes. It skips where user namespaces are unavailable, which includes the CI container.	2026-08-26 13:30:26 +01:00