POP3 RETR is missing dot-stuffing and CRLF termination #3

New Issue

2026-06-17T17:12:07+01:00

lyrathorpe commented

2026-06-17 17:12:07 +01:00

handle_retr (proxy_server.py:271) writes the raw body and then a "." terminator with no byte-stuffing.

RFC 1939 requires, for multi-line responses:

Any line beginning with "." must be byte-stuffed with a leading ".".
The body must be CRLF-terminated before the "."CRLF terminator.

A message containing a line starting with "." (e.g. ".signature") or a body not ending in CRLF will truncate or corrupt the transfer.

Fix:

Normalise line endings to CRLF.
Byte-stuff lines beginning with ".".
Emit the terminating "."CRLF on its own line.

Acceptance:

A message body containing a line beginning with "." is transferred intact.

handle_retr (proxy_server.py:271) writes the raw body and then a "." terminator with no byte-stuffing. RFC 1939 requires, for multi-line responses: - Any line beginning with "." must be byte-stuffed with a leading ".". - The body must be CRLF-terminated before the "."CRLF terminator. A message containing a line starting with "." (e.g. ".signature") or a body not ending in CRLF will truncate or corrupt the transfer. Fix: - Normalise line endings to CRLF. - Byte-stuff lines beginning with ".". - Emit the terminating "."CRLF on its own line. Acceptance: - A message body containing a line beginning with "." is transferred intact.

lyrathorpe added the bug label 2026-06-17 17:12:07 +01:00

lyrathorpe referenced this issue from a commit

2026-06-17 17:22:30 +01:00

fix: correct POP3 RETR/TOP, static maildrop, and IMAP fetching

lyrathorpe referenced a pull request that will close this issue

2026-06-17 17:22:53 +01:00

Fix POP3/SMTP correctness and IMAP robustness #10

lyrathorpe closed this issue

2026-06-17 17:33:10 +01:00

lyrathorpe referenced this issue from a commit

2026-06-17 17:33:11 +01:00

Fix POP3/SMTP correctness and IMAP robustness (#10)