lyrathorpe/legacy-email-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

POP3 DELE marks are wiped by STAT/LIST/UIDL #2

New Issue
Closed
opened 2026-06-17 17:12:04 +01:00 by lyrathorpe · 0 comments
lyrathorpe commented 2026-06-17 17:12:04 +01:00
Owner
Copy Link
Copy Source

POP3Session._refresh_mailbox (proxy_server.py:225) calls self.deleted.clear(), and handle_stat, handle_list and handle_uidl all invoke _refresh_mailbox() on every call.

A normal client sequence (DELE 1; STAT; QUIT) loses the pending deletion: STAT clears the deleted set, so handle_quit expunges nothing.

RFC 1939 also requires the maildrop to be locked and static for the duration of the session; re-listing mid-session shifts message numbers under the client.

Fix:

  • Snapshot the UID list once at authentication.
  • Do not clear the deleted set on STAT/LIST/UIDL.
  • Remove _refresh_mailbox and its mid-session calls.

Acceptance:

  • DELE followed by STAT/LIST/UIDL then QUIT still expunges the marked messages.
  • Message numbering is stable for the lifetime of the session.
POP3Session._refresh_mailbox (proxy_server.py:225) calls self.deleted.clear(), and handle_stat, handle_list and handle_uidl all invoke _refresh_mailbox() on every call. A normal client sequence (DELE 1; STAT; QUIT) loses the pending deletion: STAT clears the deleted set, so handle_quit expunges nothing. RFC 1939 also requires the maildrop to be locked and static for the duration of the session; re-listing mid-session shifts message numbers under the client. Fix: - Snapshot the UID list once at authentication. - Do not clear the deleted set on STAT/LIST/UIDL. - Remove _refresh_mailbox and its mid-session calls. Acceptance: - DELE followed by STAT/LIST/UIDL then QUIT still expunges the marked messages. - Message numbering is stable for the lifetime of the session.
lyrathorpe added the bug label 2026-06-17 17:12:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect / incorrect behaviour
 ci
CI / build pipeline
 docs
Documentation
 enhancement
Improvement to existing behaviour
 security
Security hardening
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lyrathorpe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lyrathorpe/legacy-email-proxy#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?